Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force a run of the setup playbook after a db failover #18120

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Force a run of the setup playbook after a db failover #18120

merged 2 commits into from
Nov 5, 2018

Conversation

carbonin
Copy link
Member

This should also update the ansible database configuration
which will allow embedded ansible to recover after a failover

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543340

@carbonin
Move the logic around when to run the setup playbook into a method
3ec10e6 
This makes the main condition easier to read and lets us add on to
the new method.
@carbonin
Force a run of the setup playbook after a db failover
792eff0 
This should also update the ansible database configuration
which will allow embedded ansible to recover after a failover

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543340
@miq-bot
Copy link
Member

miq-bot commented Oct 22, 2018

Checked commits carbonin/manageiq@3ec10e6~...792eff0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@carbonin carbonin changed the title [WIP] Force a run of the setup playbook after a db failover Force a run of the setup playbook after a db failover Oct 23, 2018
@carbonin carbonin removed the wip label Oct 23, 2018
@carbonin
Copy link
Member Author

Just finished testing this. Looks like it does the job. @gtanzillo whenever you get a chance this should be good to review.

@carbonin carbonin requested a review from bdunne November 5, 2018 14:36
@bdunne bdunne merged commit e5cc6fc into ManageIQ:master Nov 5, 2018
@bdunne bdunne added this to the Sprint 98 Ending Nov 5, 2018 milestone Nov 5, 2018
@bdunne bdunne assigned bdunne and unassigned gtanzillo Nov 5, 2018
simaishi pushed a commit that referenced this pull request Nov 5, 2018
@bdunne @simaishi
Merge pull request #18120 from carbonin/recover_embedded_ansible_afte…
e0f7546 
…r_failover

Force a run of the setup playbook after a db failover

(cherry picked from commit e5cc6fc)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543340
@simaishi
Copy link
Contributor

simaishi commented Nov 5, 2018

Hammer backport details:

$ git log -1
commit e0f75466848b2d0305797cdf0c6a3481710e525a
Author: Brandon Dunne <[email protected]>
Date:   Mon Nov 5 09:48:08 2018 -0500

    Merge pull request #18120 from carbonin/recover_embedded_ansible_after_failover
    
    Force a run of the setup playbook after a db failover
    
    (cherry picked from commit e5cc6fc5c9e515053f43ed054b7b2e27b48488b8)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543340

@carbonin carbonin deleted the recover_embedded_ansible_after_failover branch August 16, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne Awaiting requested review from bdunne

Assignees

@bdunne bdunne

Labels
bug core hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carbonin @miq-bot @simaishi @gtanzillo @bdunne